From e322a78cbfd6d51aefe26425dff1cb99c3d307bc Mon Sep 17 00:00:00 2001 From: Fabian Groffen Date: Fri, 21 Apr 2023 21:09:05 +0200 Subject: libq/tree: add commetns on file checks (research for bug #898194) Signed-off-by: Fabian Groffen --- libq/tree.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/libq/tree.c b/libq/tree.c index f308c8d..1922b7d 100644 --- a/libq/tree.c +++ b/libq/tree.c @@ -1109,8 +1109,17 @@ tree_pkg_read(tree_pkg_ctx *pkg_ctx) if (ctx->cachetype == CACHE_METADATA_MD5) { ret = tree_read_file_md5(pkg_ctx); + /* md5-cache, is sort of documented in egencache man-page + * key-points are that an md5 is provided for the ebuild itself, + * and if it includes eclasses, the md5s for each eclass. These + * are available as _md5_ and _eclasses_ keys. The latter uses + * tab-separation of form \t\t... */ } else if (ctx->cachetype == CACHE_METADATA_PMS) { ret = tree_read_file_pms(pkg_ctx); + /* PMS implies to do an mtime and existence check (the cache may + * contain extra stuff) but since this form of metadata in fact + * is extinct, because these checks are insufficient and + * impossible on e.g. a git-based tree. */ } else if (ctx->cachetype == CACHE_EBUILD) { ret = tree_read_file_ebuild(pkg_ctx); } else if (ctx->cachetype == CACHE_BINPKGS) { -- cgit v1.2.3-65-gdbad