diff options
| author |   Luiz Capitulino <lcapitulino@redhat.com> | 2009-12-14 18:53:20 -0200 |
|---|---|---|
| committer |   Anthony Liguori <aliguori@us.ibm.com> | 2009-12-18 11:26:27 -0600 |
| commit | 29ec3156ee66b6e2553a0adb2f35cb143edddc5f (patch) | |
| tree | 32cbacc1ba3a98d50614aac0a976fc53d411378d | |
| parent | qdev: Improve uni-north device names (diff) | |
| download | qemu-kvm-29ec3156ee66b6e2553a0adb2f35cb143edddc5f.tar.gz qemu-kvm-29ec3156ee66b6e2553a0adb2f35cb143edddc5f.tar.bz2 qemu-kvm-29ec3156ee66b6e2553a0adb2f35cb143edddc5f.zip | |
QDict: Fix size update
Key replacement should not update the dictionary's size.
This commit also adds a test for the bug.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | check-qdict.c | 2 | ||||
| -rw-r--r-- | qdict.c | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/check-qdict.c b/check-qdict.c index c37d44822..f2b482656 100644 --- a/check-qdict.c +++ b/check-qdict.c @@ -205,6 +205,8 @@ START_TEST(qdict_put_exists_test) value = qdict_get_int(tests_dict, key); fail_unless(value == 2); + + fail_unless(qdict_size(tests_dict) == 1); } END_TEST @@ -122,9 +122,8 @@ void qdict_put_obj(QDict *qdict, const char *key, QObject *value) /* allocate a new entry */ entry = alloc_entry(key, value); QLIST_INSERT_HEAD(&qdict->table[hash], entry, next); + qdict->size++; } - - qdict->size++; } /** |