Some QA on quoting and ebuild style

(Portage version: 2.2.0_alpha4/cvs/Linux x86_64)

4 files changed, 14 insertions, 9 deletions

diff --git a/media-gfx/povray/ChangeLog b/media-gfx/povray/ChangeLog
index d909b90029fa..f83df5fbbd21 100644
--- a/media-gfx/povray/ChangeLog
+++ b/media-gfx/povray/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for media-gfx/povray
 # Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/ChangeLog,v 1.106 2010/11/14 14:36:43 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/ChangeLog,v 1.107 2010/11/14 14:40:52 jlec Exp $
+
+  14 Nov 2010; Justin Lecher <jlec@gentoo.org> povray-3.6.1-r4.ebuild,
+  povray-3.7.0_beta35.ebuild, povray-3.7.0_beta38.ebuild:
+  Some QA on quoting and ebuild style
 
   14 Nov 2010; Justin Lecher <jlec@gentoo.org> povray-3.7.0_beta38.ebuild:
   Fix for compilation on prefix
diff --git a/media-gfx/povray/povray-3.6.1-r4.ebuild b/media-gfx/povray/povray-3.6.1-r4.ebuild
index cf931b6c610f..53e2afc2928a 100644
--- a/media-gfx/povray/povray-3.6.1-r4.ebuild
+++ b/media-gfx/povray/povray-3.6.1-r4.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.6.1-r4.ebuild,v 1.10 2010/08/13 10:45:28 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.6.1-r4.ebuild,v 1.11 2010/11/14 14:40:52 jlec Exp $
 
 inherit flag-o-matic eutils autotools
 
@@ -19,6 +19,7 @@ DEPEND="media-libs/libpng
 	sys-libs/zlib
 	X? ( x11-libs/libXaw )
 	svga? ( media-libs/svgalib )"
+RDEPEND="${DEPEND}"
 
 src_unpack() {
 	unpack ${A}
@@ -65,8 +66,7 @@ src_compile() {
 		COMPILED_BY="Portage (Gentoo `uname`) on `hostname -f`" \
 		$(use_with svga) \
 		$(use_with tiff) \
-		$(use_with X) \
-		|| die
+		$(use_with X)
 
 	emake || die
 }
diff --git a/media-gfx/povray/povray-3.7.0_beta35.ebuild b/media-gfx/povray/povray-3.7.0_beta35.ebuild
index 016ea983f9df..bd88243712b3 100644
--- a/media-gfx/povray/povray-3.7.0_beta35.ebuild
+++ b/media-gfx/povray/povray-3.7.0_beta35.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta35.ebuild,v 1.3 2010/06/01 12:58:33 lavajoe Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta35.ebuild,v 1.4 2010/11/14 14:40:52 jlec Exp $
 
 inherit eutils autotools flag-o-matic versionator
 
@@ -28,6 +28,7 @@ DEPEND="media-libs/libpng
 	sys-libs/zlib
 	X? ( x11-libs/libXaw )
 	>=dev-libs/boost-1.36"
+RDEPEND="${DEPEND}"
 
 S="${WORKDIR}/${PN}-${MY_PV}"
 
@@ -90,8 +91,7 @@ src_compile() {
 		COMPILED_BY="Portage (Gentoo `uname`) on `hostname -f`" \
 		$(use_with tiff libtiff) \
 		$(use_with X x) \
-		--disable-strip \
-		|| die
+		--disable-strip
 
 	emake || die
 }
diff --git a/media-gfx/povray/povray-3.7.0_beta38.ebuild b/media-gfx/povray/povray-3.7.0_beta38.ebuild
index 896dd0217b5d..0db30ac8b70b 100644
--- a/media-gfx/povray/povray-3.7.0_beta38.ebuild
+++ b/media-gfx/povray/povray-3.7.0_beta38.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta38.ebuild,v 1.3 2010/11/14 14:36:43 jlec Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-gfx/povray/povray-3.7.0_beta38.ebuild,v 1.4 2010/11/14 14:40:52 jlec Exp $
 
 EAPI="3"
 
@@ -35,6 +35,7 @@ DEPEND="
 	mkl? ( sci-libs/mkl )
 	tiff? ( >=media-libs/tiff-3.6.1 )
 	X? ( media-libs/libsdl )"
+RDEPEND="${DEPEND}"
 
 S="${WORKDIR}/${PN}-${MY_PV}"
 
@@ -98,7 +99,7 @@ src_configure() {
 		--disable-strip \
 		--disable-optimiz \
 		--disable-optimiz-arch \
-		--with-boost-libdir=${EPREFIX}/usr/$(get_libdir)
+		--with-boost-libdir="${EPREFIX}"/usr/$(get_libdir)
 }
 
 src_test() {