summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTony Vroon <chainsaw@gentoo.org>2009-12-07 00:30:55 +0000
committerTony Vroon <chainsaw@gentoo.org>2009-12-07 00:30:55 +0000
commit07fa12bbdb6f7d97a8748fef73ad1e932b70b7ba (patch)
treed18e17f221b69ba8cd83c13e85ff40b417156762 /sys-apps/lcdtest
parentVersion bump. (diff)
downloadgentoo-2-07fa12bbdb6f7d97a8748fef73ad1e932b70b7ba.tar.gz
gentoo-2-07fa12bbdb6f7d97a8748fef73ad1e932b70b7ba.tar.bz2
gentoo-2-07fa12bbdb6f7d97a8748fef73ad1e932b70b7ba.zip
QA audit as requested by Tomáš "scarabeus" Chvátal on #gentoo-dev; abort if there is no binary/manpage/documentation to install. Multi-stage ppmtoxpm/sed die was defective, replaced.
(Portage version: 2.2_rc55/cvs/Linux x86_64)
Diffstat (limited to 'sys-apps/lcdtest')
-rw-r--r--sys-apps/lcdtest/ChangeLog7
-rw-r--r--sys-apps/lcdtest/lcdtest-1.08-r1.ebuild12
2 files changed, 12 insertions, 7 deletions
diff --git a/sys-apps/lcdtest/ChangeLog b/sys-apps/lcdtest/ChangeLog
index 969dac2bfd9e..1948bab8f171 100644
--- a/sys-apps/lcdtest/ChangeLog
+++ b/sys-apps/lcdtest/ChangeLog
@@ -1,6 +1,11 @@
# ChangeLog for sys-apps/lcdtest
# Copyright 1999-2009 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/sys-apps/lcdtest/ChangeLog,v 1.15 2009/10/13 13:55:43 chainsaw Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-apps/lcdtest/ChangeLog,v 1.16 2009/12/07 00:30:55 chainsaw Exp $
+
+ 07 Dec 2009; <chainsaw@gentoo.org> lcdtest-1.08-r1.ebuild:
+ QA audit as requested by Tomáš "scarabeus" Chvátal on #gentoo-dev;
+ abort if there is no binary/manpage/documentation to install. Multi-stage
+ ppmtoxpm/sed die was defective, replaced.
13 Oct 2009; <chainsaw@gentoo.org> lcdtest-1.08-r1.ebuild:
The die command was omitted on some tests. Correct this oversight.
diff --git a/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild b/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild
index 6bb0354b1bb6..afc44b5d8c9d 100644
--- a/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild
+++ b/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild
@@ -1,6 +1,6 @@
# Copyright 1999-2009 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild,v 1.7 2009/10/13 13:55:43 chainsaw Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-apps/lcdtest/lcdtest-1.08-r1.ebuild,v 1.8 2009/12/07 00:30:55 chainsaw Exp $
inherit eutils toolchain-funcs
@@ -32,8 +32,8 @@ src_compile() {
eend $?
einfo "Generating font"
pngtopnm 14P_Arial_Plain_Red.png > help_font.ppm || die pngtopnm failed
- ppmtoxpm -name `basename help_font.ppm .ppm`_xpm help_font.ppm |
- sed 's/static //;s/black/#000000/;s/magenta/#FF00FF/;s/#E40808/#009900/' > help_font.c || die ppmtoxpm failed
+ ppmtoxpm -name `basename help_font.ppm .ppm`_xpm help_font.ppm || die ppmtoxpm failed
+ sed 's/static //;s/black/#000000/;s/magenta/#FF00FF/;s/#E40808/#009900/' > help_font.c || sed failed
ebegin "Running final stage compilation"
"${CC}" -o help_font.o -c ${CFLAGS} -DRELEASE=${PV} help_font.c || die help_font compilation failed
"${CC}" -o lcdtest lcdtest.o SFont.o help_font.o -lSDL -lSDL_image || die final link failed
@@ -41,7 +41,7 @@ src_compile() {
}
src_install() {
- dobin src/lcdtest
- doman man/lcdtest.1
- dodoc README
+ dobin src/lcdtest || die Binary missing
+ doman man/lcdtest.1 || die Manpage missing
+ dodoc README || die Documentation missing
}