aboutsummaryrefslogtreecommitdiff
path: root/sim/frv
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2016-01-03 21:40:34 -0500
committerMike Frysinger <vapier@gentoo.org>2016-01-03 22:07:39 -0500
commit77cf2ef5dc9099501529151921a73be904757466 (patch)
treeafe55fc45fb53886d73ed81e984f83222ab759a7 /sim/frv
parentsim: TODO: move to wiki (diff)
downloadbinutils-gdb-77cf2ef5dc9099501529151921a73be904757466.tar.gz
binutils-gdb-77cf2ef5dc9099501529151921a73be904757466.tar.bz2
binutils-gdb-77cf2ef5dc9099501529151921a73be904757466.zip
sim: parse_args: display getopt error ourselves
Fix a long standing todo where we let getopt write directly to stderr when an invalid option is passed. Use the sim io funcs instead as they go through the filtered callbacks that gdb wants.
Diffstat (limited to 'sim/frv')
-rw-r--r--sim/frv/ChangeLog4
-rw-r--r--sim/frv/sim-if.c4
2 files changed, 5 insertions, 3 deletions
diff --git a/sim/frv/ChangeLog b/sim/frv/ChangeLog
index 7a6b86a2daa..0be8512084d 100644
--- a/sim/frv/ChangeLog
+++ b/sim/frv/ChangeLog
@@ -1,5 +1,9 @@
2016-01-03 Mike Frysinger <vapier@gentoo.org>
+ * sim-if.c (sim_open): Update sim_parse_args comment.
+
+2016-01-03 Mike Frysinger <vapier@gentoo.org>
+
* TODO: Delete file.
2016-01-03 Mike Frysinger <vapier@gentoo.org>
diff --git a/sim/frv/sim-if.c b/sim/frv/sim-if.c
index 6bf77fde0ae..d4a61b337a0 100644
--- a/sim/frv/sim-if.c
+++ b/sim/frv/sim-if.c
@@ -83,9 +83,7 @@ sim_open (kind, callback, abfd, argv)
augment the meaning of an option. */
sim_add_option_table (sd, NULL, frv_options);
- /* getopt will print the error message so we just have to exit if this fails.
- FIXME: Hmmm... in the case of gdb we need getopt to call
- print_filtered. */
+ /* The parser will print an error message for us, so we silently return. */
if (sim_parse_args (sd, argv) != SIM_RC_OK)
{
free_state (sd);