aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorwicked%sci.fi <>2009-07-14 03:59:44 +0000
committerwicked%sci.fi <>2009-07-14 03:59:44 +0000
commita90fb5f05df1d23fd538a24a29f702d90049ffa7 (patch)
treec92cd69181862736e8fdb0e645447ebb34891998 /colchange.cgi
parentBug 369139: Add titles to creating and updating a tag messages - Patch by Tee... (diff)
downloadbugzilla-a90fb5f05df1d23fd538a24a29f702d90049ffa7.tar.gz
bugzilla-a90fb5f05df1d23fd538a24a29f702d90049ffa7.tar.bz2
bugzilla-a90fb5f05df1d23fd538a24a29f702d90049ffa7.zip
Bug 448690: Changing columns after editing a saved search forgets edits - Patch by Teemu Mannermaa <wicked@sci.fi> r/a=LpSolit
Diffstat (limited to 'colchange.cgi')
-rwxr-xr-xcolchange.cgi21
1 files changed, 7 insertions, 14 deletions
diff --git a/colchange.cgi b/colchange.cgi
index 532bfd4b6..a521ee168 100755
--- a/colchange.cgi
+++ b/colchange.cgi
@@ -141,14 +141,12 @@ if (defined $cgi->param('rememberedquery')) {
$params->param('columnlist', join(",", @collist));
$search->set_url($params->query_string());
$search->update();
- $vars->{'redirect_url'} = "buglist.cgi?".$cgi->param('rememberedquery');
- }
- else {
- my $params = new Bugzilla::CGI($cgi->param('rememberedquery'));
- $params->param('columnlist', join(",", @collist));
- $vars->{'redirect_url'} = "buglist.cgi?".$params->query_string();
}
+ my $params = new Bugzilla::CGI($cgi->param('rememberedquery'));
+ $params->param('columnlist', join(",", @collist));
+ $vars->{'redirect_url'} = "buglist.cgi?".$params->query_string();
+
# If we're running on Microsoft IIS, using cgi->redirect discards
# the Set-Cookie lines -- workaround is to use the old-fashioned
@@ -168,7 +166,9 @@ if (defined $cgi->param('rememberedquery')) {
exit;
}
-if (defined $cgi->cookie('COLUMNLIST')) {
+if (defined $cgi->param('columnlist')) {
+ @collist = split(/[ ,]+/, $cgi->param('columnlist'));
+} elsif (defined $cgi->cookie('COLUMNLIST')) {
@collist = split(/ /, $cgi->cookie('COLUMNLIST'));
} else {
@collist = DEFAULT_COLUMN_LIST;
@@ -186,13 +186,6 @@ if (defined $cgi->param('query_based_on')) {
if ($search) {
$vars->{'saved_search'} = $search;
- $vars->{'buffer'} = "cmdtype=runnamed&namedcmd=". url_quote($search->name);
-
- my $params = new Bugzilla::CGI($search->url);
- if ($params->param('columnlist')) {
- my @collist = split(',', $params->param('columnlist'));
- $vars->{'collist'} = \@collist if scalar (@collist);
- }
}
}