aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkiko%async.com.br <>2004-04-12 04:31:44 +0000
committerkiko%async.com.br <>2004-04-12 04:31:44 +0000
commitfcf2c1a1a5900f51a6e20c6b2391677bf6fb729c (patch)
treecf7053f9d72de657ec11a909632a65a96b0d7ab6 /page.cgi
parentPatch for bug 240228: Improve the format of the error message displayed by ch... (diff)
downloadbugzilla-fcf2c1a1a5900f51a6e20c6b2391677bf6fb729c.tar.gz
bugzilla-fcf2c1a1a5900f51a6e20c6b2391677bf6fb729c.tar.bz2
bugzilla-fcf2c1a1a5900f51a6e20c6b2391677bf6fb729c.zip
Fix for bug 238865-v1: remove %FORM from page.cgi. Does so, fixing the
linked page template and adding a code error for the "bad id provided" case. r=vladd, a=myk.
Diffstat (limited to 'page.cgi')
-rwxr-xr-xpage.cgi13
1 files changed, 9 insertions, 4 deletions
diff --git a/page.cgi b/page.cgi
index b68a9313b..6e78317fc 100755
--- a/page.cgi
+++ b/page.cgi
@@ -42,14 +42,19 @@ Bugzilla->login();
my $cgi = Bugzilla->cgi;
-if ($::FORM{'id'}) {
+my $id = $cgi->param('id');
+if ($id) {
# Remove all dodgy chars, and split into name and ctype.
- $::FORM{'id'} =~ s/[^\w\-\.]//g;
- $::FORM{'id'} =~ /(.*)\.(.*)/;
+ $id =~ s/[^\w\-\.]//g;
+ $id =~ /(.*)\.(.*)/;
+ if (!$2) {
+ # if this regexp fails to match completely, something bad came in
+ ThrowCodeError("bad_page_cgi_id", { "page_id" => $id });
+ }
my $format = GetFormat("pages/$1", undef, $2);
- $vars->{'form'} = \%::FORM;
+ $cgi->param('id', $id);
print $cgi->header($format->{'ctype'});