coccinelle: make use of SYNTHETIC_ERRNO

Ideally, coccinelle would strip unnecessary braces too. But I do not see any
option in coccinelle for this, so instead, I edited the patch text using
search&replace to remove the braces. Unfortunately this is not fully automatic,
in particular it didn't deal well with if-else-if-else blocks and ifdefs, so
there is an increased likelikehood be some bugs in such spots.

I also removed part of the patch that coccinelle generated for udev, where we
returns -1 for failure. This should be fixed independently.

1 files changed, 4 insertions, 6 deletions

diff --git a/src/user-sessions/user-sessions.c b/src/user-sessions/user-sessions.c
index 4f711c2ed..5ca8037cb 100644
--- a/src/user-sessions/user-sessions.c
+++ b/src/user-sessions/user-sessions.c
@@ -15,10 +15,9 @@
 static int run(int argc, char*argv[]) {
         int r, k;
 
-        if (argc != 2) {
-                log_error("This program requires one argument.");
-                return -EINVAL;
-        }
+        if (argc != 2)
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                       "This program requires one argument.");
 
         log_setup_service();
 
@@ -36,8 +35,7 @@ static int run(int argc, char*argv[]) {
         } else if (streq(argv[1], "stop"))
                 return create_shutdown_run_nologin_or_warn();
 
-        log_error("Unknown verb '%s'.", argv[1]);
-        return -EINVAL;
+        return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Unknown verb '%s'.", argv[1]);
 }
 
 DEFINE_MAIN_FUNCTION(run);