aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Gundersen <teg@jklm.no>2015-04-01 13:55:52 +0200
committerAnthony G. Basile <blueness@gentoo.org>2015-04-12 11:29:00 -0400
commitc48e712fee1ed30b15d494ea42e1b6faffaade05 (patch)
tree0ea4d81168d089bf2e6b1999acabacf6a38cda23
parentMerge branch 'master' of github.com:gentoo/eudev (diff)
downloadeudev-c48e712fee1ed30b15d494ea42e1b6faffaade05.tar.gz
eudev-c48e712fee1ed30b15d494ea42e1b6faffaade05.tar.bz2
eudev-c48e712fee1ed30b15d494ea42e1b6faffaade05.zip
libudev: monitor - improve logging
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
-rw-r--r--src/libudev/libudev-monitor.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/libudev/libudev-monitor.c b/src/libudev/libudev-monitor.c
index 07b23e9b3..26c265dc9 100644
--- a/src/libudev/libudev-monitor.c
+++ b/src/libudev/libudev-monitor.c
@@ -647,6 +647,8 @@ retry:
return NULL;
}
if (buf.nlh.properties_off+32 > (size_t)buflen) {
+ log_debug("message smaller than expected (%u > %zd)",
+ buf.nlh.properties_off+32, buflen);
return NULL;
}
@@ -670,8 +672,10 @@ retry:
}
udev_device = udev_device_new_from_nulstr(udev_monitor->udev, &buf.raw[bufpos], buflen - bufpos);
- if (!udev_device)
+ if (!udev_device) {
+ log_debug("could not create device: %m");
return NULL;
+ }
if (is_initialized)
udev_device_set_is_initialized(udev_device);
@@ -716,8 +720,10 @@ int udev_monitor_send_device(struct udev_monitor *udev_monitor,
uint64_t tag_bloom_bits;
blen = udev_device_get_properties_monitor_buf(udev_device, &buf);
- if (blen < 32)
+ if (blen < 32) {
+ log_debug("device buffer is too small to contain a valid device");
return -EINVAL;
+ }
/* fill in versioned header */
val = udev_device_get_subsystem(udev_device);